Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FPGA: Add system reset API #242

Merged
merged 1 commit into from
Aug 20, 2024
Merged

FPGA: Add system reset API #242

merged 1 commit into from
Aug 20, 2024

Conversation

secworks
Copy link
Contributor 

  Add API address to trigger system reset.
  When written to will send system_reset signal
  to the reset generator, which then perform a complete
  reset cycle of the FPGA system.

@secworks secworks requested a review from dehanj June 24, 2024 11:37
@secworks
Copy link
Contributor Author

Note that this implementation does not look at the mode. This means that both a device app and FW could trigger reset. Not sure if that is something want. It made the implementation less complex.

Also, this function dropped the clock frequency somewhat. We could try an add a register to cut combinational logic.

@dehanj
Copy link
Member

dehanj commented Jun 24, 2024

Are we missing a define in tk1_mem.h?

Should it be defined like this in tk1_mem.h?
#define TK1_MMIO_TK1_SYSTEM_RESET 0xff0001C0

@secworks
Copy link
Contributor Author

Are we missing a define in tk1_mem.h?

Should it be defined like this in tk1_mem.h? #define TK1_MMIO_TK1_SYSTEM_RESET 0xff0001C0

Ah! Yes. And Yes.

@dehanj
Copy link
Member

dehanj commented Jun 25, 2024

Did a quick test and from what I can see it works as how I expected it to.

@mchack-work
Copy link
Member

I'd like to see an update to hw/application_fpga/core/tk1/README.md describing the API to do a system reset, hopefully also describing exactly what is being reset.

@mchack-work mchack-work mentioned this pull request Jul 3, 2024
Closed
@secworks
Copy link
Contributor Author

secworks commented Jul 8, 2024

Added description of system reset API in README. Including what is reset and what happens after a reset has been triggered.

@dehanj dehanj marked this pull request as ready for review August 20, 2024 08:42
@secworks @dehanj
FPGA: Add system reset API
0059954 
      Add API address to trigger system reset.
      When written to will send system_reset signal
      to the reset generator, which then perform a complete
      reset cycle of the FPGA system.

Signed-off-by: Joachim Strömbergson <[email protected]>
@dehanj
Copy link
Member

dehanj commented Aug 20, 2024

Rebased, squashed, verified.

@dehanj dehanj merged commit 0059954 into main Aug 20, 2024
5 checks passed
@dehanj dehanj deleted the system_reset branch August 20, 2024 11:35
@dehanj dehanj mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dehanj dehanj dehanj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@secworks @dehanj @mchack-work